Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.4.x] CI: pin to an older nightly #269

Merged
merged 2 commits into from
Nov 13, 2019
Merged

[v0.4.x] CI: pin to an older nightly #269

merged 2 commits into from
Nov 13, 2019

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Nov 7, 2019

to workaround compiletest-rs being broken on recent nightlies

this is a backport of #267 and it's required to land #265

I'm not backporting #268 (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild

to workaround compiletest-rs being broken on recent nightlies
Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 7, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric

to workaround compiletest-rs being broken on recent nightlies

this is a backport of #267 and it's required to land #265 

I'm not backporting #268  (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Nov 7, 2019

Build failed

@korken89
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Nov 12, 2019
@bors
Copy link
Contributor

bors bot commented Nov 12, 2019

try

Build failed

@japaric
Copy link
Collaborator Author

japaric commented Nov 12, 2019

Build failed

Weird, I cannot reproduce this failure locally. Running rustup default nightly-2019-10-31; sh ci/script.sh works fine for me 🤔

@korken89
Copy link
Collaborator

Same here :P

@korken89
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Nov 13, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric

to workaround compiletest-rs being broken on recent nightlies

this is a backport of #267 and it's required to land #265 

I'm not backporting #268  (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Nov 13, 2019

Build succeeded

@bors bors bot merged commit 79c3afa into v0.4.x Nov 13, 2019
@bors bors bot deleted the v4-fix-ci branch November 13, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants