TST add float_cmp crate for tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
May 7, 2019
Cargo.toml
Outdated
| @@ -44,3 +44,4 @@ ndarray = "0.12.1" | |||
| sprs = "0.6.3" | |||
| unicode-segmentation = "1.2.1" | |||
| hashbrown = "0.1" | |||
| float-cmp = "0.4.0" #for asserting floating point differences in test | |||
There was a problem hiding this comment.
Maybe we could put this under the [dev-dependencies] section, as it's only needed for tests?
Nit; also maybe adding a space after the # for readability if you don't mind.
There was a problem hiding this comment.
For sure. Will do. I'll look around too for something like numpy.testing.assert_allclose.
jbowles
force-pushed
the
jbowles_clippy_float_cmp
branch
from
d143cba
to
6e6b3ef
Compare
|
Actually I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you think about adding float-cmp for doing float comparisons in test?
Clippy complains about float comparisons and I've run into it with other projects...
first time I've tried out this crate to deal with float comparisons in tests.