CI: replace compiletest-rs with trybuild #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use compiletest to run compile-fail tests but compiletest depends on compiler internals so it breaks every now and then and requires nightly. With trybuild we can also run compile-fail tests but it works on stable and it already has reached version 1.0
| warning: unused import: `rtfm::app` | ||
| --> $DIR/task-priority-too-high.rs:3:5 | ||
| | | ||
| 3 | use rtfm::app; |
There was a problem hiding this comment.
Uh, spurious warning? Is this a known rustc bug?
There was a problem hiding this comment.
The warning it's also present on 1.36.0. Perhaps this has been there for a while but compiletest ignores warnings by default?
There was a problem hiding this comment.
Yeah, that's probably what's happening
ci/script.sh
Outdated
| # compile-fail tests | ||
| cargo test --test single --target $T | ||
| # compile-fail tests | ||
| cargo test --test single --target $T |
There was a problem hiding this comment.
The compiler output might change between versions, so running this on all channels might cause issues later on
There was a problem hiding this comment.
good point. I have changed the condition to test only when rustc --version == $MSRV. $MSRV remains constant for a whole major version of rtfm (e.g. 1.36.0 for v0.5.x)
japaric
added a commit
to rtic-rs/rtic-syntax
that referenced
this pull request
Nov 7, 2019
in the same vein as rtic-rs/rtic#268
this version is more or less fixed so new releases of Rust (stable or nightly channel) are unlikely to break to build due to changes in diagnostic messages
bors bot
added a commit
that referenced
this pull request
Nov 7, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric to workaround compiletest-rs being broken on recent nightlies this is a backport of #267 and it's required to land #265 I'm not backporting #268 (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild Co-authored-by: Jorge Aparicio <jorge@japaric.io>
korken89
approved these changes
Nov 7, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 13, 2019
268: CI: replace compiletest-rs with trybuild r=japaric a=japaric We use compiletest to run compile-fail tests but compiletest depends on compiler internals so it breaks every now and then and requires nightly. With trybuild we can also run compile-fail tests but it works on stable and it already has reached version 1.0 270: Added struct de-structure-ing example in tips & tricks r=japaric a=korken89 As per last meeting, a bare-bones added that we can improve Co-authored-by: Jorge Aparicio <jorge@japaric.io> Co-authored-by: Emil Fresk <emil.fresk@gmail.com>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Nov 13, 2019
269: [v0.4.x] CI: pin to an older nightly r=korken89 a=japaric to workaround compiletest-rs being broken on recent nightlies this is a backport of #267 and it's required to land #265 I'm not backporting #268 (compiletest -> trybuild) because this branch has compile-pass tests which depend on compiletest and can't be ported to trybuild Co-authored-by: Jorge Aparicio <jorge@japaric.io>
bors bot
added a commit
to rtic-rs/rtic-syntax
that referenced
this pull request
Nov 14, 2019
19: CI: replace compiletest with trybuild r=perlindgren a=japaric in the same vein as rtic-rs/rtic#268 Co-authored-by: Jorge Aparicio <jorge@japaric.io>
bors bot
added a commit
to rtic-rs/rtic-syntax
that referenced
this pull request
Nov 14, 2019
19: CI: replace compiletest with trybuild r=perlindgren a=japaric in the same vein as rtic-rs/rtic#268 Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use compiletest to run compile-fail tests but compiletest depends on compiler
internals so it breaks every now and then and requires nightly. With trybuild we
can also run compile-fail tests but it works on stable and it already has
reached version 1.0