Store a reference to the tooltip/popover on insert #766
Conversation
…t we can more reliably use it to restore when hidden
| ); | ||
| } | ||
| const body = tip.querySelector(".popover-body"); | ||
| const el = this.bsPopoverEl; |
There was a problem hiding this comment.
Do we unset this element at some point? Or do we just update it when a new popover is inserted?
There was a problem hiding this comment.
Ah yes, good point. Addressed in cc0ac46
There was a problem hiding this comment.
I'm still left with the general feeling that the references we should track in the class instance should be to elements that we control, i.e. the popover body and title. But I also understand that this may be a quicker and easier way to solve the current bug. I'm happy if we just make a note to think about this again if we end up in this area again.
Yea, I had another quick look into this. That approach would definitely simplify some logic and make it more robust to changes to Bootstrap. The downside though is that, if we don't reach into the tooltip/popover element (to return the contents to their rightful place), then we'd open ourselves up to restoring "stale" content, which is a problem for popovers especially |
cpsievert
force-pushed
the
bs5.3-tooltip-fix
branch
from
c0b95a9
to
cc0ac46
Compare
Closes #765