Deal with new ffi Ruby version requirement #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
requested changes
May 19, 2019
Gemfile
Outdated
| elsif RUBY_VERSION < '2.0' | ||
| # ffi dropped Ruby 1.8 support in 1.9.19 | ||
| # ffi dropped Ruby 1.9 support in 1.11.0 | ||
| gem 'ffi', '< 1.9.19' |
There was a problem hiding this comment.
As per expectations, need both versions.
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2019
Deal with new ffi Ruby version requirement
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…uby_1_9 Deal with new ffi Ruby version requirement --- This commit was imported from rspec/rspec-support@4b45513.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…uby_1_9 Deal with new ffi Ruby version requirement --- This commit was imported from rspec/rspec-support@4b45513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683
Related: