Skip to content

Commit

Permalink
Update ripper_supported? for truffleruby and ripper specs to allow ex…
Browse files Browse the repository at this point in the history
…ceptions
  • Loading branch information
bjfish committed Jan 10, 2020
1 parent 596198a commit 88aee8b
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 10 deletions.
6 changes: 5 additions & 1 deletion lib/rspec/support/ruby_features.rb
Expand Up @@ -47,6 +47,10 @@ def non_mri?
def mri?
!defined?(RUBY_ENGINE) || RUBY_ENGINE == 'ruby'
end

def truffleruby?
defined?(RUBY_ENGINE) && RUBY_ENGINE == 'truffleruby'
end
end

# @api private
Expand Down Expand Up @@ -101,7 +105,7 @@ def supports_taint?
end
ripper_requirements = [ComparableVersion.new(RUBY_VERSION) >= '1.9.2']

ripper_requirements.push(false) if Ruby.rbx?
ripper_requirements.push(false) if Ruby.rbx? || Ruby.truffleruby?

if Ruby.jruby?
ripper_requirements.push(Ruby.jruby_version >= '1.7.5')
Expand Down
26 changes: 17 additions & 9 deletions spec/rspec/support/ruby_features_spec.rb
Expand Up @@ -126,21 +126,29 @@ def ripper_works_correctly?
# https://github.com/jruby/jruby/issues/3386
def ripper_reports_correct_line_number?
in_sub_process_if_possible do
require 'ripper'
tokens = ::Ripper.lex('foo')
token = tokens.first
location = token.first
line_number = location.first
line_number == 1
begin
require 'ripper'
tokens = ::Ripper.lex('foo')
token = tokens.first
location = token.first
line_number = location.first
line_number == 1
rescue
false
end
end
end

# https://github.com/jruby/jruby/issues/4562
def ripper_can_parse_source_including_keywordish_symbol?
in_sub_process_if_possible do
require 'ripper'
sexp = ::Ripper.sexp(':if')
!sexp.nil?
begin
require 'ripper'
sexp = ::Ripper.sexp(':if')
!sexp.nil?
rescue
false
end
end
end

Expand Down

0 comments on commit 88aee8b

Please sign in to comment.