Skip to content

Commit

Permalink
Update ripper_supported? for truffleruby and ripper specs to only run…
Browse files Browse the repository at this point in the history
… when supported
  • Loading branch information
bjfish committed Jan 13, 2020
1 parent 596198a commit 41872c7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 7 deletions.
6 changes: 5 additions & 1 deletion lib/rspec/support/ruby_features.rb
Expand Up @@ -47,6 +47,10 @@ def non_mri?
def mri?
!defined?(RUBY_ENGINE) || RUBY_ENGINE == 'ruby'
end

def truffleruby?
defined?(RUBY_ENGINE) && RUBY_ENGINE == 'truffleruby'
end
end

# @api private
Expand Down Expand Up @@ -101,7 +105,7 @@ def supports_taint?
end
ripper_requirements = [ComparableVersion.new(RUBY_VERSION) >= '1.9.2']

ripper_requirements.push(false) if Ruby.rbx?
ripper_requirements.push(false) if Ruby.rbx? || Ruby.truffleruby?

if Ruby.jruby?
ripper_requirements.push(Ruby.jruby_version >= '1.7.5')
Expand Down
16 changes: 10 additions & 6 deletions spec/rspec/support/ruby_features_spec.rb
Expand Up @@ -126,12 +126,16 @@ def ripper_works_correctly?
# https://github.com/jruby/jruby/issues/3386
def ripper_reports_correct_line_number?
in_sub_process_if_possible do
require 'ripper'
tokens = ::Ripper.lex('foo')
token = tokens.first
location = token.first
line_number = location.first
line_number == 1
begin
require 'ripper'
tokens = ::Ripper.lex('foo')
token = tokens.first
location = token.first
line_number = location.first
line_number == 1
rescue NoMethodError
false # TruffleRuby defines Ripper but implementation is not complete
end
end
end

Expand Down

0 comments on commit 41872c7

Please sign in to comment.