Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use headless driver for next Rails release #2746

Merged
merged 6 commits into from
Mar 19, 2024

Commits on Mar 16, 2024

  1. Use headless driver for next Rails release

    In the next release of Rails, the default driver was switched from
    `:chrome` to `:headless_chrome` as see in: rails/rails#50512
    This is to ensure the new [ci template][] will "work out of the box".
    
    However, this will not work with applications using `rspec-rails`, since
    it still defaults to `:selenium`. Instead, GitHub actions will fail with
    the following error:
    
    ```
    Selenium::WebDriver::Error::SessionNotCreatedError:
                session not created: Chrome failed to start: exited normally.
                  (session not created: DevToolsActivePort file doesn't exist)
                  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
    ```
    
    [ci template]: https://github.com/rails/rails/blob/main/railties/lib/rails/generators/rails/app/templates/github/ci.yml.tt
    stevepolitodesign committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    6f49c11 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. [WIP] Attempt to fix CI failure

    Rails `main` is [currently][] set to `7.2.0.alpha`. However, `ci.yml`
    uses `'main'` for the `RAILS_VERSION`.
    
    [currently]: https://github.com/rails/rails/blob/5ab13c5a7798c2a9f96bebb1c68285dfb842d4f9/RAILS_VERSION
    stevepolitodesign committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f122744 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Revert "[WIP] Attempt to fix CI failure"

    This reverts commit f122744.
    stevepolitodesign committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a9b0295 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0036262 View commit details
    Browse the repository at this point in the history
  3. Split spec per Rails version

    JonRowe committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    633025b View commit details
    Browse the repository at this point in the history
  4. Restore whitespace

    JonRowe committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    937b2d9 View commit details
    Browse the repository at this point in the history