Rename filenames from travis to ci #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I could find |
|
@pirj I didn't find any usage of those files in this project and I wasn't sure if that's either a legacy code or it's used somehow by Travis lifecycle. |
|
Those files are/were hooks for the build to run at various points, its possible they aren't used in this project anymore. |
Maroo-b
force-pushed
the
2435_rename_travis_to_ci
branch
from
b287d4e
to
732fc4a
Compare
|
@JonRowe thanks for the input, I updated the names of these script files as well. |
|
Do you mind giving it a try and remove |
|
In theory, it should be fine to remove those files, I'll update the PR |
This is a fix for rspec#2435
Maroo-b
force-pushed
the
2435_rename_travis_to_ci
branch
from
732fc4a
to
aa84175
Compare
|
Happy to help :) |
JonRowe
pushed a commit
that referenced
this pull request
Apr 21, 2021
Rename filenames from travis to ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2435
I tried to follow the approach used in this PR: https://github.com/rspec/rspec-dev/pull/254/files by renaming only filenames and leave the internal function names to have
travisas a prefix (as it's used specifically for Travis)