Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the expectation for predicate methods #2353

Merged
merged 2 commits into from Jun 10, 2020
Merged

Change the expectation for predicate methods #2353

merged 2 commits into from Jun 10, 2020

Commits on Jun 10, 2020

  1. Change the expectation for predicate methods 

    Predicate methods typically return true or false, this is part of an
associated bug-fix in rspec/rspec-core#2736 but as rspec-rails is now
a separate entity we must account for this ourselves.

Note some predicates are here by default settings and may be able to
be tidied up in `rspec-rails` 5.
    @pirj @JonRowe
    pirj authored and JonRowe committed Jun 10, 2020
    2 Configuration menu
    Copy the full SHA
    c6779d6 View commit details
    Browse the repository at this point in the history

  2. Supress module length lint for configuration

    @JonRowe
    JonRowe committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9d5c6ee View commit details
    Browse the repository at this point in the history