Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison of times for #at in job matchers. #2304

Merged
merged 1 commit into from Mar 28, 2020
Merged

Fix comparison of times for #at in job matchers. #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/rspec/rails/matchers/active_job.rb
View file
Open in desktop
Expand Up @@ -30,8 +30,12 @@ def on_queue(queue)
self
end

def at(date)
@at = date
def at(time_or_date)
case time_or_date
when Time then @at = Time.at(time_or_date.to_f)
else
@at = time_or_date
end
self
end

Expand Down
7 changes: 7 additions & 0 deletions spec/rspec/rails/matchers/active_job_spec.rb
View file
Open in desktop
Expand Up @@ -216,6 +216,13 @@ def self.name; "LoggingJob"; end
}.to have_enqueued_job.at(date)
end

it "passes with provided at time" do
time = Time.now + 1.day
expect {
hello_job.set(wait_until: time).perform_later
}.to have_enqueued_job.at(time)
end

it "accepts composable matchers as an at date" do
future = 1.minute.from_now
slightly_earlier = 58.seconds.from_now
Expand Down