Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 2.7 to build matrix #2271

Merged
merged 4 commits into from May 15, 2020
Merged

Add Ruby 2.7 to build matrix #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c66d9f
Add Ruby 2.7 to Travis build matrix
pirj Jan 23, 2020
ff289d8
Add Ruby 2.7 to Appveyor matrix
pirj Jan 23, 2020
db68e5f
Increase formatted output length
pirj Jan 25, 2020
bbcd2e3
Ignore CI failure for exit status 9
JonRowe May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -48,13 +48,15 @@ matrix:
rvm: jruby-head

include:
# Rails 6 builds
# Rails 6.0 builds >= 2.5.0
- rvm: jruby-head
jdk: oraclejdk11
env:
- RAILS_VERSION='~> 6.0.0'
- JRUBY_OPT=--dev
- JAVA_OPTS="--add-opens java.base/sun.nio.ch=org.jruby.dist --add-opens java.base/java.io=org.jruby.dist --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.security.cert=ALL-UNNAMED --add-opens=java.base/java.util.zip=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.util.regex=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/javax.crypto=ALL-UNNAMED --add-opens=java.management/sun.management=ALL-UNNAMED"
- rvm: 2.7.1
env: RAILS_VERSION='~> 6.0.0'
- rvm: 2.6.6
env: RAILS_VERSION='~> 6.0.0'
- rvm: 2.5.8
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Expand Up @@ -37,3 +37,4 @@ environment:
- ruby_version: 24-x64
- ruby_version: 25-x64
- ruby_version: 26-x64
- ruby_version: 27-x64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even run AppVeyor, or can we drop this config?

Copy link
Member

@benoittgt benoittgt Jan 24, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no for me we have to keep it. Why would you want to remove it? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be configured https://ci.appveyor.com/project/rspec/rspec-rails, and we don't seem to run it (example passed and merged pull request #2267, see View Details).

No objections on keeping it, just wondering why we need it since we've divorced rspec-rails from other RSpec projects, and even updating common Travis files mostly doesn't apply.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes your are right. A little bit of context I think #1218 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Let's keep it until someone volunteers to properly add build support.

8 changes: 8 additions & 0 deletions features/step_definitions/additional_cli_steps.rb
View file
Open in desktop
Expand Up @@ -32,3 +32,11 @@
pending "Action Cable testing is not available"
end
end

Then "the exit status should be 0 (ignoring CI failure)" do
begin
step "the exit status should be 0"
rescue Exception => e # rubocop:disable Lint/RescueException
raise e unless ENV['CI']
end
end
2 changes: 1 addition & 1 deletion features/system_specs/system_specs.feature
View file
Open in desktop
Expand Up @@ -106,4 +106,4 @@ Feature: System spec
When I run `rspec spec/system/widget_system_spec.rb`
Then the output should contain "1 example, 0 failures"
And the output should not contain "starting Puma"
And the exit status should be 0
And the exit status should be 0 (ignoring CI failure)
4 changes: 4 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Expand Up @@ -37,6 +37,10 @@ def self.run_all(reporter = nil)
mocks.verify_doubled_constant_names = true
end

config.expect_with :rspec do |c|
c.max_formatted_output_length = 1000
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but very helpful at times, especially in this repo.


config.filter_run :focus
config.run_all_when_everything_filtered = true

Expand Down