Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .travis.yml inline with rspec-core #21

Merged
merged 4 commits into from Sep 12, 2019
Merged

Update .travis.yml inline with rspec-core #21

merged 4 commits into from Sep 12, 2019

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Sep 8, 2019

No description provided.

benoittgt
benoittgt approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@benoittgt benoittgt self-requested a review September 9, 2019 09:43
@benoittgt
Copy link
Member

Sorry I didn't see the CI had few errors.

@benoittgt
Copy link
Member

That's sad. We fail on ffi 1.11.1. And at the same time ffi/ffi@a9439f2#diff-354f30a63fb0907d4ad57269548329e3
Before the CI was always failing.

Also in ffi/ffi#660 (comment)

The FFI gem currently assumes that Ruby implementations other than MRI and Rubinius have their own equivalent FFI replacement.

Should we allow failures for rbx?

@JonRowe
Copy link
Member Author

JonRowe commented Sep 12, 2019

Having got ffi to install on rbx, its still broken so I'm adding to allow failures for now

@JonRowe JonRowe merged commit bccb1f7 into master Sep 12, 2019
@JonRowe JonRowe deleted the update-build branch September 12, 2019 19:24
@benoittgt
Copy link
Member

Thanks Jon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt Awaiting requested review from benoittgt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonRowe @benoittgt