Deal with new ffi Ruby version requirement #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems failing because of rspec-mocks ffi build error. So rspec/rspec-mocks#1276 |
benoittgt
changed the title
JonRowe
requested changes
May 19, 2019
Gemfile
Outdated
| elsif RUBY_VERSION < '2.0' | ||
| # ffi dropped Ruby 1.8 support in 1.9.19 | ||
| # ffi dropped Ruby 1.9 support in 1.11.0 | ||
| gem 'ffi', '< 1.9.19' |
There was a problem hiding this comment.
Mistake here, you've not got the split versions.
|
I also removed 81b6039 because I don't see any error with |
JonRowe
approved these changes
May 19, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
|
Fail on appveyor seems unrelated. |
JonRowe
pushed a commit
that referenced
this pull request
Oct 7, 2019
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…c-expectations#1115) CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-expectations@dbf72e5.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…c-expectations#1115) CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699 --- This commit was imported from rspec/rspec-expectations@1044d4e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi/ffi#683
Related: