Fix ci #3064
Fix ci #3064
Conversation
Failure/Error: require 'drb/drb' LoadError: cannot load such file -- drb/drb # ./lib/rspec/core/drb.rb:1:in `require' # ./lib/rspec/core/drb.rb:1:in `<top (required)>' # ./spec/rspec/core/invocations_spec.rb:1:in `require' # ./spec/rspec/core/invocations_spec.rb:1:in `<top (required)>'
| @@ -103,4 +103,6 @@ end | |||
|
|
|||
| gem 'contracts', '< 0.16' if RUBY_VERSION < '1.9.0' | |||
|
|
|||
| gem 'drb' if RUBY_VERSION >= '3.4' | |||
There was a problem hiding this comment.
If this is fixing [or attempting to] fix an extraction of drb on Ruby head it is not enough, we rely on drb and it will cause weird issues if its missing, so we need to actually detect the presence of drb [and test for it] issuing a warning etc.
There was a problem hiding this comment.
Fair enough. I’ll implement a warning separately.
We do rely on drb in bisect, don’t we? But we have a fallback?
There was a problem hiding this comment.
In the bisector but also there is a DRb mode that supported things like spork and other things, we will need to check for any usage and appropriately load it / issue a warning when it is not present
| @@ -204,7 +204,7 @@ def foo | |||
| Failure/Error: __send__(method, file) | |||
| EOS | |||
|
|
|||
| if RUBY_VERSION.to_f > 3.2 | |||
| if RUBY_VERSION > '3.2.2' | |||
There was a problem hiding this comment.
The fix backported from 3.3 to 3.2.3? It was omitting that line on 3.2.2, but it’s there on 3.2.3
https://github.com/rspec/rspec-core/actions/runs/7660333335/job/20877413523?pr=3046
https://github.com/rspec/rspec-core/actions/runs/7660333335/job/20877410640?pr=3046