Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize exception_lines in ExceptionPresenter #2743

Merged
merged 1 commit into from Jun 29, 2020
Merged

Memoize exception_lines in ExceptionPresenter #2743

merged 1 commit into from Jun 29, 2020

Commits on Jun 29, 2020

  1. Memoize exception_lines in ExceptionPresenter 

    The method failure_lines uses exception_lines 3 times, which uses exception.message.
In some situation, exception.message can be slow (when inspect is called on a big object for example).
Without caching, this delay which can become considerable will be amplified by 3x.
    @MaxLap
    MaxLap committed Jun 29, 2020
    Copy the full SHA
    2eb6e50 View commit details
    Browse the repository at this point in the history