Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid be_falsey and be_truthy #2736

Merged
merged 9 commits into from Jun 18, 2020
Merged

Avoid be_falsey and be_truthy #2736

merged 9 commits into from Jun 18, 2020

Commits on Jun 4, 2020

  1. Define correct predicates such that config.xxx? returns true/false 

    Notes:
* no idea why the `remove_method` is needed now and wasn't needed previously
* no spec failure as specs use `be_falsey` and `be_truthy`
    @marcandre
    marcandre committed Jun 4, 2020
    Copy the full SHA
    d020a8c View commit details
    Browse the repository at this point in the history

  2. Avoid be_truthy / be_falsey

    @marcandre
    marcandre committed Jun 4, 2020
    Copy the full SHA
    e961660 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Increase the default formatted output's length 

    Warning text that includes file paths was cut off when a spec was
failing due to a Ruby warning.
    @pirj
    pirj committed Jun 5, 2020
    Copy the full SHA
    2616deb View commit details
    Browse the repository at this point in the history

  2. Skip defining the reader 

    We define the reader as a method down the lines anyway.
core_spec was issuing a warning that this method is redefined.
    @pirj
    pirj committed Jun 5, 2020
    Copy the full SHA
    0e2a20d View commit details
    Browse the repository at this point in the history

  3. Adjust method names 

    `define_aliases` actually only defined one.

`define_predicate_for` was always passed a single argument.
    @pirj
    pirj committed Jun 5, 2020
    Copy the full SHA
    685117c View commit details
    Browse the repository at this point in the history

  4. Simplify the expectation

    @pirj
    pirj committed Jun 5, 2020
    Copy the full SHA
    6f46e39 View commit details
    Browse the repository at this point in the history

  5. Typo fix

    @marcandre
    marcandre committed Jun 5, 2020
    Copy the full SHA
    841df69 View commit details
    Browse the repository at this point in the history

  6. Restore trivial example

    @marcandre
    marcandre committed Jun 5, 2020
    Copy the full SHA
    4f05d41 View commit details
    Browse the repository at this point in the history

  7. Use define_method instead of class_eval

    @marcandre
    marcandre committed Jun 5, 2020
    Copy the full SHA
    e7df10c View commit details
    Browse the repository at this point in the history