Add a missing Cucumber scenario #2695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`after` blocks are run no matter if given example has succeeded or not. This is normal behaviour, and this very commit adds a respective Cucumber scenario. Fixes rspec#2692.
pirj
reviewed
Feb 4, 2020
| end | ||
|
|
||
| example "deliberate failure" do | ||
| expect(true).to be(false) |
There was a problem hiding this comment.
It's pretty obvious that after hooks are being run for failed examples.
I believe the original issue had in mind an example that raises an exception:
it do
raise "in example"
endDo you mind to change this feature to reflect that scenario?
For completeness, it would be nice to have scenarios when the example is pending or skipped.
JonRowe
requested changes
Feb 4, 2020
| @@ -300,6 +300,31 @@ Feature: `before` and `after` hooks | |||
| after suite | |||
| """ | |||
|
|
|||
| Scenario: `after` blocks are run also for examples which have failed or encountered other errors | |||
There was a problem hiding this comment.
Suggested change
| Scenario: `after` blocks are run also for examples which have failed or encountered other errors | |
| Scenario: `after` blocks are run regardless of the result of the example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
afterblocks are run no matter if given example has succeeded or not. This is normal behaviour, and this very commit adds a respective Cucumber scenario.Fixes #2692.
Feel free to reword the commit or added scenario if needed.