Fix treatment of rake task option as an Array.

Found because `array =~ /.../` is deprecated in 2.7 and generates a warning in Ruby 2.6.
rspec · Mar 15, 2020 · e894c64 · e894c64
1 parent 7b4b2b9
commit e894c64
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rspec/core/rake_task.rb b/lib/rspec/core/rake_task.rb
@@ -122,7 +122,7 @@ def file_inclusion_specification
         if ENV['SPEC']
           FileList[ENV['SPEC']].sort
         elsif String === pattern && !File.exist?(pattern)
-          return if rspec_opts =~ /--pattern/
+          return if [*rspec_opts].any? { |opt| opt =~ /--pattern/ }
           "--pattern #{escape pattern}"
         else
           # Before RSpec 3.1, we used `FileList` to get the list of matched

diff --git a/spec/rspec/core/rake_task_spec.rb b/spec/rspec/core/rake_task_spec.rb
@@ -77,6 +77,13 @@ def spec_command
           exclude(escape(RSpec::Core::RakeTask::DEFAULT_PATTERN))
         )
       end
+
+      it 'behaves properly if rspec_opts is an array' do
+        task.rspec_opts = %w[--pattern some_specs]
+        expect(spec_command).to include("--pattern some_specs").and(
+          exclude(escape(RSpec::Core::RakeTask::DEFAULT_PATTERN))
+        )
+      end
     end
 
     context "with pattern" do