Skip to content

Commit

Permalink
Add spec to prevent zombie status
Browse files Browse the repository at this point in the history
  • Loading branch information
JonRowe authored and benoittgt committed Aug 28, 2020
1 parent f3f0593 commit e676b3f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion spec/integration/bisect_spec.rb
Expand Up @@ -33,14 +33,19 @@ def bisect(cli_args, expected_status=nil)
end
end

context "when the bisect commasaturingnd is long" do
context "when the bisect command saturates the pipe" do
# On OSX and Linux a file descriptor limit meant that the bisect process got stuck at a certain limit.
# This test demonstrates that we can run large bisects above this limit (found to be at time of commit).
# See: https://github.com/rspec/rspec-core/pull/2669
it 'does not hit pipe size limit and does not get stuck' do
output = bisect(%W[spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_], 1)
expect(output).to include("No failures found.")
end

it 'does not leave zombie processes', :unless => RSpec::Support::OS.windows? do
bisect(%W[spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_], 1)
expect(%x[ps -ho pid,state]).to_not include("Z")
end
end
end
end

0 comments on commit e676b3f

Please sign in to comment.