Deal with new ffi Ruby version requirement #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
May 19, 2019
Gemfile
Outdated
| @@ -44,6 +44,8 @@ if RUBY_VERSION.to_f < 2 | |||
| gem 'json', '< 2' | |||
| gem 'term-ansicolor', '< 1.4.0' # used by cucumber | |||
| gem 'tins', '~> 1.6.0' # used by term-ansicolor | |||
| # ffi dropped Ruby 1.8 support in 1.9.19 and Ruby 1.9 support in 1.11.0 | |||
| gem 'ffi', '< 1.9.19' | |||
There was a problem hiding this comment.
Its better to have the split version requirement.
CI was failing for 1.9.2 and 1.9.3. This is due to ffi/ffi#683 Related: - ffi/ffi#699
|
CI nightmare. I am not able to bundle locally with ruby 1.8.7. I have another error with I don't understand why one build passed https://travis-ci.org/rspec/rspec-collection_matchers/pull_requests the commit was c0110eb |
|
CI is green since. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
I was not able to build it locally. ffi failed to install. So I am not sure it will work.