Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shelljs version 0.8.4 #146

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Conversation

dylanjustice
Copy link
Contributor

Resolves #145

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • [/] Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)

@dylanjustice dylanjustice added the dependencies Pull requests that update a dependency file label Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #146 (10f7997) into main (dbfd744) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   77.50%   77.75%   +0.24%     
==========================================
  Files          28       28              
  Lines        1218     1218              
  Branches      182      182              
==========================================
+ Hits          944      947       +3     
+ Misses        239      236       -3     
  Partials       35       35              
Impacted Files Coverage Δ
modules/github.js 68.83% <0.00%> (+0.93%) ⬆️
modules/js.js 96.29% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfd744...64d880a. Read the comment docs.

@brandongregoryscott brandongregoryscott merged commit 2f17224 into rsm-hcd:main Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 14 warnings "non existent property"
2 participants