Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate Arel code from Rails to Oracle enhanced adapter #2001

Closed
wants to merge 1 commit into from

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Apr 14, 2020

This is a draft pull request to support rails/rails#38946

Required

  • Migrate Arel library code to make CI green
  • Migrate git commit history

Optional

  • Migrate test code
    because the unit test for Arel is written in Minitest, Oracle enhanced adapter uses RSpec. Arel has been a private API at Rails then it may be fine without tests for the time being.

@yahonda
Copy link
Collaborator Author

yahonda commented Apr 14, 2020

@koic I'd like to get your help how to migrate Arel library code with git commit history. I think you have done a similar job at rubocop/rubocop#5977 (comment)

@koic
Copy link
Collaborator

koic commented Apr 15, 2020

Yeah, I will try this one.

@koic
Copy link
Collaborator

koic commented Apr 15, 2020

I created the following branch to solve this.
https://github.com/koic/oracle-enhanced/tree/merge_arel_visitors

It passes specs using remove_unused_visitors branch of kamipo/rails repository.

gem "activerecord",   github: "kamipo/rails", branch: "remove_unused_visitors"

You can cherry-pick these commits into this PR or I can open a new PR If you'd like.
koic/oracle-enhanced@e7d3240...af14bb0

@yahonda
Copy link
Collaborator Author

yahonda commented Apr 15, 2020

@koic Thanks for the great work! Would you open a new pull request?

@koic koic mentioned this pull request Apr 15, 2020
@koic
Copy link
Collaborator

koic commented Apr 15, 2020

I opened PR #2002. Thank you.

@yahonda
Copy link
Collaborator Author

yahonda commented Apr 15, 2020

Closing this draft pull request.

@yahonda yahonda closed this Apr 15, 2020
@yahonda yahonda deleted the migrate_arel_code_from_rails branch July 13, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants