fix(diode): atomic.AddUint64 in 32-bit cause panic (#229)

see: https://golang.org/pkg/sync/atomic/#pkg-note-BUG
rs · May 11, 2020 · e86e8f2 · e86e8f2
1 parent de5a95d
commit e86e8f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/diode/internal/diodes/many_to_one.go b/diode/internal/diodes/many_to_one.go
@@ -9,9 +9,9 @@ import (
 // ManyToOne diode is optimal for many writers (go-routines B-n) and a single
 // reader (go-routine A). It is not thread safe for multiple readers.
 type ManyToOne struct {
-	buffer     []unsafe.Pointer
 	writeIndex uint64
 	readIndex  uint64
+	buffer     []unsafe.Pointer
 	alerter    Alerter
 }
 

diff --git a/diode/internal/diodes/one_to_one.go b/diode/internal/diodes/one_to_one.go
@@ -31,9 +31,9 @@ type bucket struct {
 // OneToOne diode is meant to be used by a single reader and a single writer.
 // It is not thread safe if used otherwise.
 type OneToOne struct {
-	buffer     []unsafe.Pointer
 	writeIndex uint64
 	readIndex  uint64
+	buffer     []unsafe.Pointer
 	alerter    Alerter
 }