New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just need to check the last byte. #89

Merged

rs merged 1 commit into rs:master from robxyy:robx/check-rs/2022-10-09

Oct 9, 2022

Contributor

robxyy commented Oct 9, 2022

Refer: #71 #75

old:

go test -bench 'FromString*' -benchmem
goos: darwin
goarch: arm64
pkg: github.com/rs/xid
BenchmarkFromString-10    	445015340	         2.618 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/rs/xid	1.807s

new:

go test -bench 'FromString*' -benchmem
goos: darwin
goarch: arm64
pkg: github.com/rs/xid
BenchmarkFromString-10    	521384266	         2.304 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/rs/xid	1.556s


          Just need to check the last byte.

5b7ab15

rs merged commit 1b855c3 into rs:master

kazk mentioned this pull request

Should check the last byte in Id::from_str kazk/xid-rs#9

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment