Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From string validation #75

Merged
merged 4 commits into from Mar 10, 2022
Merged

From string validation #75

merged 4 commits into from Mar 10, 2022

Commits on Mar 4, 2022

  1. chore: address linter issues 

    Perform changes suggested by linter; no functional changes.
    @smyrman
    smyrman committed Mar 4, 2022
    Copy the full SHA
    b64cbc7 View commit details
    Browse the repository at this point in the history

  2. error.go: make ErrInvalidID a const 

    Make ErrInvalidID a constant instead of a variable. This prevent it from
being changed by external packages; a behavior that although allowed by 
the compiler, should probably be considered an invalid operation.
    @smyrman
    smyrman committed Mar 4, 2022
    Copy the full SHA
    2171fc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. add benchmark and new failing test for FromString

    @smyrman
    smyrman committed Mar 10, 2022
    Copy the full SHA
    f288272 View commit details
    Browse the repository at this point in the history

  2. fix: let decode look for additional base32 padding 

    Update FromString and XID.TextUnmarshal so that it looks for discarded
bits in the final source character. This ensures that XIDs that have
been manually tampered with in a way that's ignored by base32 decode,
will not pass as valid.
    @smyrman
    smyrman committed Mar 10, 2022
    Copy the full SHA
    06d3085 View commit details
    Browse the repository at this point in the history