Add test reproducing #646

rrrene · Mar 30, 2019 · dd0d568 · dd0d568
1 parent 024ffff
commit dd0d568
Show file tree

Hide file tree

Showing 4 changed files with 152 additions and 0 deletions.
diff --git a/test/credo/code/charlists_test.exs b/test/credo/code/charlists_test.exs
@@ -32,4 +32,42 @@ defmodule Credo.Code.CharlistsTest do
 
     assert expected == source |> Charlists.replace_with_spaces()
   end
+
+  test "it should not modify commented out code" do
+    source = """
+    defmodule Foo do
+      defmodule Bar do
+        # @doc \"\"\"
+        # Reassign a student to a discussion group.
+        # This will un-assign student from the current discussion group
+        # \"\"\"
+        # def assign_group(leader = %User{}, student = %User{}) do
+        #   cond do
+        #     leader.role == :student ->
+        #       {:error, :invalid}
+        #
+        #     student.role != :student ->
+        #       {:error, :invalid}
+        #
+        #     true ->
+        #       Repo.transaction(fn ->
+        #         {:ok, _} = unassign_group(student)
+        #
+        #         %Group{}
+        #         |> Group.changeset(%{})
+        #         |> put_assoc(:leader, leader)
+        #         |> put_assoc(:student, student)
+        #         |> Repo.insert!()
+        #       end)
+        #   end
+        # end
+        def baz, do: 123
+      end
+    end
+    """
+
+    expected = source
+
+    assert expected == source |> Charlists.replace_with_spaces(".")
+  end
 end
diff --git a/test/credo/code/heredocs_test.exs b/test/credo/code/heredocs_test.exs
@@ -114,4 +114,42 @@ defmodule Credo.Code.HeredocsTest do
     result = source |> Heredocs.replace_with_spaces(".")
     assert expected == result
   end
+
+  test "it should not modify commented out code" do
+    source = """
+    defmodule Foo do
+      defmodule Bar do
+        # @doc \"\"\"
+        # Reassign a student to a discussion group.
+        # This will un-assign student from the current discussion group
+        # \"\"\"
+        # def assign_group(leader = %User{}, student = %User{}) do
+        #   cond do
+        #     leader.role == :student ->
+        #       {:error, :invalid}
+        #
+        #     student.role != :student ->
+        #       {:error, :invalid}
+        #
+        #     true ->
+        #       Repo.transaction(fn ->
+        #         {:ok, _} = unassign_group(student)
+        #
+        #         %Group{}
+        #         |> Group.changeset(%{})
+        #         |> put_assoc(:leader, leader)
+        #         |> put_assoc(:student, student)
+        #         |> Repo.insert!()
+        #       end)
+        #   end
+        # end
+        def baz, do: 123
+      end
+    end
+    """
+
+    expected = source
+
+    assert expected == source |> Heredocs.replace_with_spaces(".")
+  end
 end
diff --git a/test/credo/code/sigils_test.exs b/test/credo/code/sigils_test.exs
@@ -176,4 +176,42 @@ defmodule Credo.Code.SigilsTest do
 
     assert expected == Sigils.replace_with_spaces(source, "")
   end
+
+  test "it should not modify commented out code" do
+    source = """
+    defmodule Foo do
+      defmodule Bar do
+        # @doc \"\"\"
+        # Reassign a student to a discussion group.
+        # This will un-assign student from the current discussion group
+        # \"\"\"
+        # def assign_group(leader = %User{}, student = %User{}) do
+        #   cond do
+        #     leader.role == :student ->
+        #       {:error, :invalid}
+        #
+        #     student.role != :student ->
+        #       {:error, :invalid}
+        #
+        #     true ->
+        #       Repo.transaction(fn ->
+        #         {:ok, _} = unassign_group(student)
+        #
+        #         %Group{}
+        #         |> Group.changeset(%{})
+        #         |> put_assoc(:leader, leader)
+        #         |> put_assoc(:student, student)
+        #         |> Repo.insert!()
+        #       end)
+        #   end
+        # end
+        def baz, do: 123
+      end
+    end
+    """
+
+    expected = source
+
+    assert expected == Sigils.replace_with_spaces(source, "")
+  end
 end
diff --git a/test/credo/code/strings_test.exs b/test/credo/code/strings_test.exs
@@ -124,4 +124,42 @@ defmodule Credo.Code.StringsTest do
     result = source |> Strings.replace_with_spaces(".")
     assert expected == result
   end
+
+  test "it should not modify commented out code" do
+    source = """
+    defmodule Foo do
+      defmodule Bar do
+        # @doc \"\"\"
+        # Reassign a student to a discussion group.
+        # This will un-assign student from the current discussion group
+        # \"\"\"
+        # def assign_group(leader = %User{}, student = %User{}) do
+        #   cond do
+        #     leader.role == :student ->
+        #       {:error, :invalid}
+        #
+        #     student.role != :student ->
+        #       {:error, :invalid}
+        #
+        #     true ->
+        #       Repo.transaction(fn ->
+        #         {:ok, _} = unassign_group(student)
+        #
+        #         %Group{}
+        #         |> Group.changeset(%{})
+        #         |> put_assoc(:leader, leader)
+        #         |> put_assoc(:student, student)
+        #         |> Repo.insert!()
+        #       end)
+        #   end
+        # end
+        def baz, do: 123
+      end
+    end
+    """
+
+    expected = source
+
+    assert expected == source |> Strings.replace_with_spaces(".")
+  end
 end