Fix Name.full for function calls

Fixes #637
rrrene · Mar 7, 2019 · 12610b9 · 12610b9
1 parent 8d4f68b
commit 12610b9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/credo/code/name.ex b/lib/credo/code/name.ex
@@ -77,8 +77,10 @@ defmodule Credo.Code.Name do
     "@#{name}"
   end
 
-  def full({:unquote, _, [{name, _, nil}]}) when is_atom(name) do
-    "unquote(#{name})"
+  def full({name, _, arguments}) when is_atom(name) and is_list(arguments) do
+    arg_list = arguments |> Enum.map(&full/1) |> Enum.join(", ")
+
+    "#{full(name)}(#{arg_list})"
   end
 
   def parts_count(module_name) do

diff --git a/test/credo/code/name_test.exs b/test/credo/code/name_test.exs
@@ -95,6 +95,16 @@ defmodule Credo.Code.NameTest do
     assert mod_list |> Name.full() == expected
   end
 
+  test "returns full name for a function call" do
+    mod_list = [
+      {:my_fun, [line: 62], [{:param1, [line: 62], nil}, {:param2, [line: 62], nil}]},
+      :Module
+    ]
+
+    expected = "my_fun(param1, param2).Module"
+    assert mod_list |> Name.full() == expected
+  end
+
   #
   # parts_count
   #