Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add providerPostfix configuration #1930

Conversation

ValentinVignal
Copy link
Contributor

Closes #1851

Add the configuration to be able to have another postfix than "Provider".

@ValentinVignal
Copy link
Contributor Author

@rrousselGit I'm creating a draft PR because I would have several questions before going further with this:

  • Do you prefer "postfix" or "suffix"?
  • How would you want me to write a test for that?
    I could create a "golden" test like what is done in riverpod_graph: I create a sub-package / app with its own pubspec.yaml and build.yaml (so I can modify the build options).
    I could for example copy the sync.dart file in it. But then do I also copy the sync_test and use all the renamed providers? This doesn't seem so right to me. Do you have any suggestions?

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1930 (6ca125e) into master (858872c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1930   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          49       49           
  Lines        2062     2062           
=======================================
  Hits         1969     1969           
  Misses         93       93           

@ValentinVignal
Copy link
Contributor Author

ValentinVignal commented Nov 22, 2022

I didn't see there already was a PR for that ... 🤦 #1898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[riverpod_generator] ability to change "Provider" postix to something else
1 participant