New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ref.exists #1844
Merged
Merged
Add Ref.exists #1844
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -191,6 +191,41 @@ abstract class Ref<State extends Object?> { | |
/// safer to use. | ||
T read<T>(ProviderListenable<T> provider); | ||
|
||
/// {@template riverpod.exists} | ||
/// Determines whether a provider is initialized or not. | ||
/// | ||
/// Writing logic that conditionally depends on the existence of a provider | ||
/// is generally unsafe and should be avoided. | ||
/// The problem is that once the provider gets initialized, logic that | ||
/// depends on the existence or not of a provider won't be rerun; possibly | ||
/// causing your state to get out of date. | ||
/// | ||
/// But it can be useful in some cases, such as to avoid re-fetching an | ||
/// object if a different network request already obtained it: | ||
/// | ||
/// ```dart | ||
/// final fetchItemList = FutureProvider<List<Item>>(...); | ||
/// | ||
/// final fetchItem = FutureProvider.autoDispose.family<Item, String>((ref, id) async { | ||
/// if (ref.exists(fetchItemList)) { | ||
/// // If `fetchItemList` is initialized, we look into its state | ||
/// // and return the already obtained item. | ||
/// final itemFromItemList = ref.watch( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Idem here, i think "await" is missing |
||
/// fetchItemList.selectAsync((items) => items.firstWhereOrNull((item) => item.id == id)), | ||
/// ); | ||
/// if (itemFromItemList != null) return itemFromItemList; | ||
/// } | ||
/// | ||
/// // If `fetchItemList` is not initialized, perform a network request for | ||
/// // "id" separately | ||
/// | ||
/// final json = await http.get('api/items/$id'); | ||
/// return Item.fromJson(json); | ||
/// }); | ||
/// ``` | ||
/// {@endtemplate} | ||
bool exists(ProviderBase<Object?> provider); | ||
|
||
/// Obtains the state of a provider and causes the state to be re-evaluated | ||
/// when that provider emits a new value. | ||
/// | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "await" is missing here. Without "await" itemFromItemList is always != null because it is a Future<Item?>