Add Ref.exists #1844
Merged
Add Ref.exists #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 49 49
Lines 2055 2059 +4
=======================================
+ Hits 1962 1966 +4
Misses 93 93
|
giandifra
reviewed
Nov 2, 2022
| /// if (ref.exists(fetchItemList)) { | ||
| /// // If `fetchItemList` is initialized, we look into its state | ||
| /// // and return the already obtained item. | ||
| /// final itemFromItemList = ref.watch( |
There was a problem hiding this comment.
I think "await" is missing here. Without "await" itemFromItemList is always != null because it is a Future<Item?>
| /// if (ref.exists(fetchItemList)) { | ||
| /// // If `fetchItemList` is initialized, we look into its state | ||
| /// // and return the already obtained item. | ||
| /// final itemFromItemList = ref.watch( |
There was a problem hiding this comment.
Idem here, i think "await" is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1843