Fix: remove unused devtool hooks

fixes #2003
rrousselGit · Dec 21, 2022 · 97e28b6 · 97e28b6
1 parent 0d1f47c
commit 97e28b6
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 177 deletions.
diff --git a/packages/riverpod/CHANGELOG.md b/packages/riverpod/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## [Unreleased patch]
 
 - Update dependencies.
+- fixes an exception on newer Dart versions
 
 ## 2.1.1
 

diff --git a/packages/riverpod/lib/src/devtool.dart b/packages/riverpod/lib/src/devtool.dart
diff --git a/packages/riverpod/lib/src/framework.dart b/packages/riverpod/lib/src/framework.dart
@@ -5,7 +5,6 @@ import 'dart:collection';
 
 import 'package:meta/meta.dart';
 import 'package:state_notifier/state_notifier.dart';
-import 'devtool.dart';
 import 'internals.dart';
 import 'stack_trace.dart';
 

diff --git a/packages/riverpod/lib/src/framework/container.dart b/packages/riverpod/lib/src/framework/container.dart
@@ -2,8 +2,6 @@ part of '../framework.dart';
 
 ProviderBase? _circularDependencyLock;
 
-int _debugNextId = 0;
-
 class _FamilyOverrideRef {
   _FamilyOverrideRef(this.override, this.container);
 
@@ -118,18 +116,6 @@ class ProviderContainer implements Node {
               if (!entry.value.isDynamicallyCreated) entry.key: entry.value,
         },
         _root = parent?._root ?? parent {
-    assert(
-      () {
-        _debugId = '${_debugNextId++}';
-        RiverpodBinding.debugInstance.containers = {
-          ...RiverpodBinding.debugInstance.containers,
-          _debugId: this,
-        };
-        return true;
-      }(),
-      '',
-    );
-
     if (parent != null) {
       parent._children.add(this);
       _overrideForFamily.addAll(parent._overrideForFamily);
@@ -174,30 +160,10 @@ class ProviderContainer implements Node {
   late final _ProviderScheduler _scheduler =
       _parent?._scheduler ?? _ProviderScheduler();
 
-  late final String _debugId;
-
   /// How deep this [ProviderContainer] is in the graph of containers.
   ///
   /// Starts at 0.
   final int depth;
-
-  /// A unique ID for this object, used by the devtool to differentiate two [ProviderContainer].
-  ///
-  /// Should not be used.
-  @visibleForTesting
-  String get debugId {
-    String? id;
-    assert(
-      () {
-        id = _debugId;
-        return true;
-      }(),
-      '',
-    );
-
-    return id!;
-  }
-
   final ProviderContainer? _root;
   final ProviderContainer? _parent;
 
@@ -638,16 +604,6 @@ final b = Provider((ref) => ref.watch(a), dependencies: [a]);
       return;
     }
 
-    assert(
-      () {
-        RiverpodBinding.debugInstance.containers =
-            Map.from(RiverpodBinding.debugInstance.containers)
-              ..remove(_debugId);
-        return true;
-      }(),
-      '',
-    );
-
     _parent?._children.remove(this);
 
     _disposed = true;

diff --git a/packages/riverpod/lib/src/framework/element.dart b/packages/riverpod/lib/src/framework/element.dart
@@ -231,9 +231,6 @@ abstract class ProviderElementBase<State> implements Ref<State>, Node {
     _mounted = true;
     assert(
       () {
-        RiverpodBinding.debugInstance
-            .providerListChangedFor(containerId: container._debugId);
-
         _debugCurrentCreateHash = provider.debugGetCreateSourceHash?.call();
 
         return true;
@@ -855,15 +852,6 @@ The provider ${_debugCurrentlyBuildingElement!.origin} modified $origin while bu
   @protected
   @mustCallSuper
   void dispose() {
-    assert(
-      () {
-        RiverpodBinding.debugInstance
-            .providerListChangedFor(containerId: container._debugId);
-        return true;
-      }(),
-      '',
-    );
-
     runOnDispose();
 
     // TODO test invalidateSelf() then dispose() properly unlinks dependencies

diff --git a/packages/riverpod/test/matchers.dart b/packages/riverpod/test/matchers.dart