[Fix rubocop#6915] Fix false positive in Style/SafeNavigation with a …

…modifier condition safe guarding a logic jump keyword

CHANGELOG.md

@@ -22,6 +22,7 @@
 * [#6860](https://github.com/rubocop-hq/rubocop/issues/6860): Prevent auto-correct conflict of `Style/InverseMethods` and `Style/Not`. ([@hoshinotsuyoshi][])
 * [#6935](https://github.com/rubocop-hq/rubocop/issues/6935): `Layout/AccessModifierIndentation` should ignore access modifiers that apply to specific methods. ([@deivid-rodriguez][])
 * [#6956](https://github.com/rubocop-hq/rubocop/issues/6956): Prevent auto-correct confliction of `Lint/Lambda` and `Lint/UnusedBlockArgument`. ([@koic][])
+* [#6915](https://github.com/rubocop-hq/rubocop/issues/6915): Fix false positive in `Style/SafeNavigation` when a modifier if is safe guarding a method call being passed to `break`, `fail`, `next`, `raise`, `return`, `throw`, and `yield`. ([@rrosenblum][])
 
 ### Changes
 

lib/rubocop/cop/style/safe_navigation.rb

@@ -65,6 +65,8 @@ class SafeNavigation < Cop
 
         MSG = 'Use safe navigation (`&.`) instead of checking if an object ' \
               'exists before calling the method.'.freeze
+        LOGIC_JUMP_KEYWORDS = %i[break fail next raise
+                                 return throw yield].freeze
 
         minimum_target_ruby_version 2.3
 
@@ -149,6 +151,7 @@ def extract_parts_from_if(node)
 
           checked_variable, matching_receiver, method =
             extract_common_parts(receiver, variable)
+          matching_receiver = nil if LOGIC_JUMP_KEYWORDS.include?(receiver.type)
           [checked_variable, matching_receiver, receiver, method]
         end
 

spec/rubocop/cop/style/safe_navigation_spec.rb

@@ -151,6 +151,25 @@
 
     shared_examples 'all variable types' do |variable|
       context 'modifier if' do
+        shared_examples 'safe guarding logical break keywords' do |keyword|
+          it "allows a method call being passed to #{keyword} safe guarded " \
+            'by an object check' do
+            expect_no_offenses(<<-RUBY.strip_indent)
+              something.each do
+                #{keyword} #{variable}.bar if #{variable}
+              end
+            RUBY
+          end
+        end
+
+        it_behaves_like 'safe guarding logical break keywords', 'break'
+        it_behaves_like 'safe guarding logical break keywords', 'fail'
+        it_behaves_like 'safe guarding logical break keywords', 'next'
+        it_behaves_like 'safe guarding logical break keywords', 'raise'
+        it_behaves_like 'safe guarding logical break keywords', 'return'
+        it_behaves_like 'safe guarding logical break keywords', 'throw'
+        it_behaves_like 'safe guarding logical break keywords', 'yield'
+
         it 'registers an offense for a method call that nil responds to ' \
         'safe guarded by an object check' do
           inspect_source("#{variable}.to_i if #{variable}")