Setuptools deprecations #1017
Merged
Setuptools deprecations #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since setuptools-62.3.0¹, a warning is issued when setuptools finds an importable package is listed in package_data rather than in packages. ¹ pypa/setuptools#3308 https://setuptools.pypa.io/en/latest/history.html#v62-3-0
In setuptools-56.0.0¹ license_file was changed to license_files. The former causes a deprecation warning. ¹ pypa/setuptools#2620 https://setuptools.pypa.io/en/latest/history.html?highlight=license_files#v56-0-0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to silence
SetuptoolsDeprecationWarnings. These were noticed when building the Fedora packages against newer python releases.rename license_file to license_files
In setuptools-56.0.0¹ license_file was changed to license_files. The
former causes a deprecation warning.
¹ License_files improvements pypa/setuptools#2620
https://setuptools.pypa.io/en/latest/history.html?highlight=license_files#v56-0-0
include rpmlint.descriptions in packages
Since setuptools-62.3.0², a warning is issued when setuptools finds an
importable package is listed in package_data rather than in packages.
² Warn about deprecation of behaviour that considers modules/packages as "data" when
include_package_data=Truepypa/setuptools#3308https://setuptools.pypa.io/en/latest/history.html#v62-3-0
It feels a little strange to list
rpmlint.descriptionsin thepackagessection as well aspackage_data. I don't know if there's a better way to do that or not. (I did try moving the line as-is frompackage_datatopackagesbut that wasn't valid.)Perhaps at some point, reworking things to just use a toml file as the more modern setuptools describes might be good?