cleanup

src/armor/writer.rs

@@ -55,7 +55,7 @@ pub fn write(
         (crc >> 8) as u8,
         crc as u8,
     ];
-    let crc_enc = base64::encode_config(&crc_buf, base64::STANDARD);
+    let crc_enc = base64::encode_config(crc_buf, base64::STANDARD);
 
     writer.write_all(crc_enc.as_bytes())?;
 

src/packet/signature/ser.rs

@@ -57,11 +57,11 @@ impl Subpacket {
                 writer.write_all(&write_string(reason))?;
             }
             Subpacket::IsPrimary(is_primary) => {
-                let val = if *is_primary { 1u8 } else { 0u8 };
+                let val = u8::from(*is_primary);
                 writer.write_all(&[val])?;
             }
             Subpacket::Revocable(is_revocable) => {
-                let val = if *is_revocable { 1u8 } else { 0u8 };
+                let val = u8::from(*is_revocable);
                 writer.write_all(&[val])?;
             }
             Subpacket::EmbeddedSignature(inner_sig) => {
@@ -100,7 +100,7 @@ impl Subpacket {
                 writer.write_all(&write_string(regexp))?;
             }
             Subpacket::ExportableCertification(is_exportable) => {
-                let val = if *is_exportable { 1 } else { 0 };
+                let val = u8::from(*is_exportable);
                 writer.write_all(&[val])?;
             }
             Subpacket::IssuerFingerprint(version, fp) => {

src/packet/signature/types.rs

@@ -152,7 +152,7 @@ impl Signature {
 
                 let mut prefix_buf = [prefix, 0u8, 0u8, 0u8, 0u8];
                 BigEndian::write_u32(&mut prefix_buf[1..], packet_buf.len() as u32);
-                debug!("prefix: {}", hex::encode(&prefix_buf));
+                debug!("prefix: {}", hex::encode(prefix_buf));
 
                 // prefixes
                 hasher.update(&prefix_buf);
@@ -777,7 +777,7 @@ impl fmt::Debug for Signature {
         f.debug_struct("Signature")
             .field("packet_version", &self.packet_version)
             .field("config", &self.config)
-            .field("signed_hash_value", &hex::encode(&self.signed_hash_value))
+            .field("signed_hash_value", &hex::encode(self.signed_hash_value))
             .field(
                 "signature",
                 &format_args!(

src/packet/user_attribute.rs

@@ -167,7 +167,7 @@ impl fmt::Debug for UserAttribute {
                 .finish(),
             UserAttribute::Unknown { typ, ref data, .. } => f
                 .debug_struct("UserAttribute::Image")
-                .field("type", &hex::encode(&[*typ]))
+                .field("type", &hex::encode([*typ]))
                 .field("data", &hex::encode(data))
                 .finish(),
         }