Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: support all date formats #2033

Merged
merged 1 commit into from Apr 1, 2024
Merged

toml: support all date formats #2033

merged 1 commit into from Apr 1, 2024

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Mar 18, 2024

TOML supports several different date formats:

2006-01-02T18:19:20Z         # UTC
2006-01-02T18:19:20+01:00    # Timezone
2006-01-02 18:19:20+01:00    # Can use space instead of "T"

2006-01-02 18:19:20          # Local date-time without timezone
2006-01-02                   # Local date
18:19:20                     # Local time

TOML supports several different date formats:

	2006-01-02T18:19:20Z         # UTC
	2006-01-02T18:19:20+01:00    # Timezone
	2006-01-02 18:19:20+01:00    # Can use space instead of "T"

	2006-01-02 18:19:20          # Local date-time without timezone
	2006-01-02                   # Local date
	18:19:20                     # Local time
@tancnle tancnle self-assigned this Mar 29, 2024
@tancnle tancnle added the needs-review The PR needs to be reviewed label Mar 29, 2024
@tancnle
Copy link
Collaborator

tancnle commented Apr 1, 2024

Thanks @arp242. LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Apr 1, 2024
Merged via the queue into rouge-ruby:master with commit 1953972 Apr 1, 2024
8 checks passed
@arp242 arp242 deleted the toml-d branch April 1, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants