Accept colon(s) in YAML key names #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdubicki
force-pushed
the
accept_colon_in_yaml_key_name
branch
from
7051a00
to
9c5ee16
Compare
|
Same PR for pygments: pygments/pygments#2277. Update: it’s merged. 😊 |
|
This is a follow-up to #1667. The main motivation is to fix the syntax highlight in GitLab, where now Puppet's Hiera is treated badly. Example:
Note how only the simple |
as it's ok according to the YAML specs and is widely used in the real world, f.e. in Puppet's Hiera (https://puppet.com/docs/puppet/7/hiera_quick.html#values_common_data)
gdubicki
force-pushed
the
accept_colon_in_yaml_key_name
branch
from
9c5ee16
to
5ffffc1
Compare
|
Thank you for your contribution @gdubicki 🙇🏼 The PR looks good to me 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it's ok according to the YAML specs and is widely used in the real world, f.e. in Puppet's Hiera
(https://puppet.com/docs/puppet/7/hiera_quick.html#values_common_data)