Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve openedge abl langage #1843

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

clement-brodu
Copy link
Contributor

Many improvement for openedge abl langage

  • disambigate .p and .cls
  • add missing file extensions
  • add alias abl
  • add missing keywords
  • improve multiline comments
  • improve preprocessor
  • improve strings

thanks for review this PR 😃

@tancnle tancnle added the needs-review The PR needs to be reviewed label Jul 4, 2022
@clement-brodu
Copy link
Contributor Author

Hello @tancnle,

Do I need to do anything else for the pull request to be accepted?
Thanks 😄

@tancnle tancnle self-requested a review April 2, 2023 06:35
@tancnle
Copy link
Collaborator

tancnle commented Apr 2, 2023

Thank you for your contributions, @clement-brodu 🙇🏼 I have added a commit for fix some styles issue 🙏🏼. Please let me know what you think. If you are happy, I can proceed with a merge 🚀

@clement-brodu
Copy link
Contributor Author

everything is ok for me ✅

thanks for your time 👍

@tancnle tancnle added this pull request to the merge queue Apr 2, 2023
Merged via the queue into rouge-ruby:master with commit be4d825 Apr 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants