Python: Support conversion specifiers in format strings #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chvp Thank you for your contribution ❤️ TIL about conversion in format string syntax.
It will be great to constrain the rule as you said. Would it be possible to do that in this PR? FYI, |
chvp
force-pushed
the
python-format-conversion
branch
from
653aa3e
to
0d38c30
Compare
|
I updated it so it is constrained to |
|
@tancnle Is anything blocking this from being merged? |
|
@chvp Sorry for the delay. I think this is a good change. We would have to look into extending this support for the standard string in the future.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1800. Format string syntax can be found here: https://docs.python.org/3/library/string.html#format-string-syntax
Technically only
[asr]is allowed after!. If wanted, I could make the entire![asr]punctuation (or something else entirely), but parsing the specifier as a generic Python expression (so in practice, an identifier) seems fine to me.