Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Idris language #1464

Merged
merged 17 commits into from
Feb 1, 2022

Conversation

bmwant
Copy link
Contributor

@bmwant bmwant commented Mar 16, 2020

Description

Testing

  • Added specs
  • Tested with visual/demo examples

image

@bmwant
Copy link
Contributor Author

bmwant commented Mar 18, 2020

hey @pyrmont, could you take a look?

@pyrmont
Copy link
Contributor

pyrmont commented Mar 22, 2020

@bmwant Sorry not to have got around to this yet. I'm afraid I haven't had much time to spend on Rouge of late but will try to remedy that soon!

@pyrmont pyrmont self-requested a review March 22, 2020 01:52
@pyrmont pyrmont self-assigned this Mar 22, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Mar 22, 2020
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Have a couple of comments:

lib/rouge/lexers/idris.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/idris.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/idris.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/idris.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/idris.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Mar 24, 2020
@pyrmont pyrmont removed their assignment Dec 9, 2020
@tancnle
Copy link
Collaborator

tancnle commented Sep 23, 2021

👋🏼 @bmwant we would love to hear back from you. Is there anything we can help to push this PR forward?

@bmwant
Copy link
Contributor Author

bmwant commented Sep 25, 2021

@tancnle hey, I can recall that I've faced a couple of blocking issues when trying to address these simple at a first glance comments. I cannot remember whether it was related to the Ruby language (as I'm not a Ruby developer per se) or to the implementation details of the lexer itself (regex lexers are trickier to implement).
If that's something related to the language I'll reach back here with my questions/clarifications, but in case it's the latter (and I suspect it's more likely) I just don't have enough mental energy to face again that horrible process of debugging 😢

@tancnle
Copy link
Collaborator

tancnle commented Sep 26, 2021

@bmwant Thank you for getting back to me. I am happy to lend a hand with the latter. Idris is an interesting language and this addition to Rouge will definitely improve the exp. for our developers.

I will review those comments from @pyrmont and help to address them in the meantime.

@nickdrozd
Copy link

Would it be possible to add a simpler version of Idris highlighting first, and then polish it later? I've been using Haskell highlighting for my Idris code blocks, and that looks terrible, so for me any real Idris support at all would be an improvement.

(I'm afraid I don't have anything concrete to offer in terms of this PR. This is just a suggestion to take the simpler-sooner route.)

@tancnle
Copy link
Collaborator

tancnle commented Jan 18, 2022

@bmwant I have pushed some changes to address the feedback from @pyrmont. Could you please have another look? 🙏🏼

@tancnle
Copy link
Collaborator

tancnle commented Feb 1, 2022

@bmwant In the spirit of iteration, I will merge this change 👍🏼. Please let me know if you have any concerns and/or raise another PR to address them. Again, thank a lot for your hard work on this PR 🙇🏼

@tancnle tancnle merged commit ba54616 into rouge-ruby:master Feb 1, 2022
@tancnle tancnle removed the author-action The PR has been reviewed but action by the author is needed label Feb 1, 2022
nickdrozd added a commit to nickdrozd/nickdrozd.github.io that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants