Ensure XML lexer handles unknown DOCTYPEs (#1348)

The Mason lexer mistakenly handles unknown DOCTYPEs. This commit ensures that the XML lexer handles unknown DOCTYPEs and adds a test to prevent future regressions.
rouge-ruby · Oct 13, 2019 · abbf5fa · abbf5fa
1 parent b357204
commit abbf5fa
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lib/rouge/lexers/mason.rb b/lib/rouge/lexers/mason.rb
@@ -15,11 +15,6 @@ def initialize(*)
         @perl = Perl.new
       end
 
-      def self.detect?(text)
-        return false if text.doctype?(/((?:ht|x)ml)/)
-        return true if text.doctype?
-      end
-
       # Note: If you add a tag in the lines below, you also need to modify "disambiguate '*.m'" in file disambiguation.rb
       TEXT_BLOCKS = %w(text doc)
       PERL_BLOCKS = %w(args flags attr init once shared perl cleanup filter)

diff --git a/spec/lexers/xml_spec.rb b/spec/lexers/xml_spec.rb
@@ -34,6 +34,7 @@
       assert_guess :source => '<?xml version="1.0" ?><html destdir="${reportfolderPath}" encoding="utf-8" />'
       assert_guess :source => '<!DOCTYPE xml>'
       deny_guess   :source => '<!DOCTYPE html>'
+      assert_guess :source => '<!DOCTYPE unknown>'
     end
   end
 end