Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize "fix" for 5432 after new occurence #6309

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

LefterisJP
Copy link
Member

As I wrote in
#5432 (comment) the issue popped up again in a different place.

This means that this driver bug is more generic and can hit us in many different places.

So I am moving the "fix" to the cursor itself.

We really need to find a proper fix for this

As I wrote in
rotki#5432 (comment) the
issue popped up again in a different place.

This means that this driver bug is more generic and can hit us in many
different places.

So I am moving the "fix" to the cursor itself.

We really need to find a proper fix for this
@LefterisJP
Copy link
Member Author

The only failing tests were uniswap and rotkehlchen/tests/unit/test_eth2.py::test_scrape_validator_withdrawals which was just a hiccup

@LefterisJP LefterisJP merged commit 111b13c into rotki:develop Jun 23, 2023
10 of 13 checks passed
@LefterisJP LefterisJP temporarily deployed to cassette-merge June 23, 2023 09:11 — with GitHub Actions Inactive
@LefterisJP LefterisJP deleted the more_5432 branch June 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant