Various changes centered around fixing 5432 #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh goody. Tests failed here and there. Let's see if this makes sense to continue looking into. |
Codecov Report
@@ Coverage Diff @@
## develop #6071 +/- ##
===========================================
- Coverage 79.72% 79.36% -0.36%
===========================================
Files 1092 1092
Lines 115017 115054 +37
Branches 10071 10073 +2
===========================================
- Hits 91693 91313 -380
- Misses 21623 22053 +430
+ Partials 1701 1688 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LefterisJP
force-pushed
the
small_shit
branch
2 times, most recently
from
e2b45ee
to
f396c2e
Compare
Achieved by using tuples. Also using Sequence as type in all relevant functions, which is an immutable sequence. Matches either tuple or list or any other sequence used immutably.
Removed the lock in rotki#6067 It was though the error was only in Detach which needed the transaction lock that was introduced there. But unfortunately a multiple attach can also result in an error so we need the lock too
Add a test that reliably reproduces the flaky Error binding parameter 0 - probably unsupported type.
This is a "temporary fix" for the error binding parameter 0 flaky error as seen in rotki#5432. If I understand it correctly the bug is in the python sqlite drivers and as such this is just a patch until it's solved properly. We have a test to reproduce so we should periodically check as we upgrade python versions to see if this is fixed and then we can revert.
LefterisJP
changed the title
|
I am gonna merge this, though there is still a known issue with |
LefterisJP
commented
May 14, 2023
| @@ -110,8 +111,7 @@ def get_accounts_having_proxy(self) -> dict[ChecksumEvmAddress, ChecksumEvmAddre | |||
|
|
|||
| with self.node_inquirer.database.conn.read_ctx() as cursor: | |||
| accounts = self.node_inquirer.database.get_blockchain_accounts(cursor) | |||
| eth_accounts = accounts.eth | |||
| mapping = self.get_accounts_proxy(eth_accounts) | |||
| mapping = self.get_accounts_proxy(accounts.get(self.node_inquirer.blockchain)) | |||
There was a problem hiding this comment.
This was another bug I found. We always were taking eth accounts here irrespective of the evm chain type
|
rotki/test-caching/tree/small_shit was successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockchainAccounts lists are now tuples -- immutable
Also using Sequence as type in all relevant functions, which is an
immutable sequence. Matches either tuple or list or any other sequence
used immutably. As these should not be modified at any point apart from when reading from the DB or adding/removing an address to/from the DB.
This was all done in order to try and reproduce and find the root cause for this: #5432
But apart from liquity module where there was addresses being added, but on a carefully made copy I did not see anything else where mypy had warnings.
Evm chain bug
Fix bug where eth_accounts were always used irrespective of chain id
Reproduce and "fix" 5432
Finally reproduced 5432 reliably in a test and provided a bad fix. For more info read the issue.