Suppress a warning around BoundedVector. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment has more explanation, but in short GCC 13 has false positives around some warnings, so we suppress it for BoundedVector. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
ahcorde
approved these changes
Apr 23, 2024
|
sloretz
approved these changes
Apr 23, 2024
|
Hm, Linux should have been green here. I don't know what is going on, I'll have to take another look. |
|
Oh, it looks like CI was run against the wrong branch. Here is another try:
|
delete-merged-branch
bot
deleted the
clalancette/suppress-bounded-vector-warning
branch
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
The comment has more explanation, but in short GCC 13 has false positives around some warnings, so we suppress it for BoundedVector. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 858e76a)
ahcorde
pushed a commit
that referenced
this pull request
Apr 25, 2024
The comment has more explanation, but in short GCC 13 has false positives around some warnings, so we suppress it for BoundedVector. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 858e76a) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment has more explanation, but in short GCC 13 has false positives around some warnings, so we suppress it for BoundedVector.