Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings - strict-prototypes #800

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 17, 2024

There are new warnings on CI related with this compiler option strict-prototypes

https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

Let's put this on the queue to merge after the freeze is lifted.

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

Errors on arch64 are related with a bug in gcc, in particular in mimick

mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'

@ahcorde ahcorde merged commit 2579950 into rolling Apr 23, 2024
4 checks passed
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

https://github.com/Mergifyio backport jazzy

@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/warnings_strict_prototipe branch April 23, 2024 11:36
Copy link

mergify bot commented Apr 23, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 23, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 2579950)
ahcorde added a commit that referenced this pull request Apr 23, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 2579950)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants