Global use of nodiscard (#801)

* Global use of nodiscard Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
ros2 · Apr 24, 2024 · 2e4d84d · 2e4d84d
1 parent 858e76a
commit 2e4d84d
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 0 deletions.
diff --git a/rosidl_runtime_cpp/include/rosidl_runtime_cpp/action_type_support_decl.hpp b/rosidl_runtime_cpp/include/rosidl_runtime_cpp/action_type_support_decl.hpp
@@ -27,6 +27,7 @@ namespace rosidl_runtime_cpp
  * \return Function handler for the action's typesupport.
  */
 template<typename T>
+[[nodiscard]]
 const rosidl_action_type_support_t * get_action_type_support_handle();
 
 }  // namespace rosidl_runtime_cpp

diff --git a/rosidl_runtime_cpp/include/rosidl_runtime_cpp/bounded_vector.hpp b/rosidl_runtime_cpp/include/rosidl_runtime_cpp/bounded_vector.hpp
@@ -724,6 +724,7 @@ class BoundedVector
    * \param y A %BoundedVector of the same type as @a x
    * \return True if the size and elements of the vectors are equal
   */
+  [[nodiscard]]
   friend bool
   operator==(
     const BoundedVector & x,
@@ -744,6 +745,7 @@ class BoundedVector
    * \param y A %BoundedVector of the same type as @a x
    * @return True if @a x is lexicographically less than @a y
   */
+  [[nodiscard]]
   friend bool
   operator<(
     const BoundedVector & x,
@@ -753,6 +755,7 @@ class BoundedVector
   }
 
   /// Based on operator==
+  [[nodiscard]]
   friend bool
   operator!=(
     const BoundedVector & x,
@@ -762,6 +765,7 @@ class BoundedVector
   }
 
   /// Based on operator<
+  [[nodiscard]]
   friend bool
   operator>(
     const BoundedVector & x,
@@ -771,6 +775,7 @@ class BoundedVector
   }
 
   /// Based on operator<
+  [[nodiscard]]
   friend bool
   operator<=(
     const BoundedVector & x,
@@ -780,6 +785,7 @@ class BoundedVector
   }
 
   /// Based on operator<
+  [[nodiscard]]
   friend bool
   operator>=(
     const BoundedVector & x,

diff --git a/rosidl_runtime_cpp/include/rosidl_runtime_cpp/message_type_support_decl.hpp b/rosidl_runtime_cpp/include/rosidl_runtime_cpp/message_type_support_decl.hpp
@@ -27,6 +27,7 @@ namespace rosidl_runtime_cpp
  * \return Function handler for the message's typesupport.
  */
 template<typename T>
+[[nodiscard]]
 const rosidl_message_type_support_t * get_message_type_support_handle();
 
 }  // namespace rosidl_runtime_cpp

diff --git a/rosidl_runtime_cpp/include/rosidl_runtime_cpp/service_type_support_decl.hpp b/rosidl_runtime_cpp/include/rosidl_runtime_cpp/service_type_support_decl.hpp
@@ -27,6 +27,7 @@ namespace rosidl_runtime_cpp
  * \return Function handler for the service's typesupport.
  */
 template<typename T>
+[[nodiscard]]
 const rosidl_service_type_support_t * get_service_type_support_handle();
 
 }  // namespace rosidl_runtime_cpp

diff --git a/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/action_type_support.hpp b/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/action_type_support.hpp
@@ -22,6 +22,7 @@ namespace rosidl_typesupport_cpp
 {
 
 template<typename T>
+[[nodiscard]]
 const rosidl_action_type_support_t * get_action_type_support_handle();
 
 }  // namespace rosidl_typesupport_cpp

diff --git a/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/message_type_support.hpp b/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/message_type_support.hpp
@@ -22,6 +22,7 @@ namespace rosidl_typesupport_cpp
 {
 
 template<typename T>
+[[nodiscard]]
 const rosidl_message_type_support_t * get_message_type_support_handle();
 
 }  // namespace rosidl_typesupport_cpp

diff --git a/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/service_type_support.hpp b/rosidl_runtime_cpp/include/rosidl_typesupport_cpp/service_type_support.hpp
@@ -25,6 +25,7 @@ namespace rosidl_typesupport_cpp
 {
 
 template<typename T>
+[[nodiscard]]
 const rosidl_service_type_support_t * get_service_type_support_handle();
 
 template<typename T>

diff --git a/...rospection_cpp/include/rosidl_typesupport_introspection_cpp/message_type_support_decl.hpp b/...rospection_cpp/include/rosidl_typesupport_introspection_cpp/message_type_support_decl.hpp
@@ -28,6 +28,7 @@ namespace rosidl_typesupport_introspection_cpp
 /// the rosidl_generate_interfaces() macro.
 /// This is implemented in the shared library provided by this package.
 template<typename T>
+[[nodiscard]]
 ROSIDL_TYPESUPPORT_INTROSPECTION_CPP_PUBLIC
 const rosidl_message_type_support_t * get_message_type_support_handle();
 

diff --git a/...rospection_cpp/include/rosidl_typesupport_introspection_cpp/service_type_support_decl.hpp b/...rospection_cpp/include/rosidl_typesupport_introspection_cpp/service_type_support_decl.hpp
@@ -27,6 +27,7 @@ namespace rosidl_typesupport_introspection_cpp
 /// services.
 /// This is implemented in the shared library provided by this package.
 template<typename T>
+[[nodiscard]]
 ROSIDL_TYPESUPPORT_INTROSPECTION_CPP_PUBLIC
 const rosidl_service_type_support_t * get_service_type_support_handle();