Remove the line numbering in examples. #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inconsistent with having the boxes be cut-n-paste. We also have to rewrite a small amount of text around it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Aut0R3V
approved these changes
Sep 6, 2021
aprotyas
reviewed
Sep 6, 2021
I don't anticipate reverting it only for these tutorials. That is, I'd like to keep the style of the tutorials consistent, and none of the other tutorials use line numbers. If we decide to implement line numbers for all tutorials, then that would be fine. |
|
Thanks for the reviews! I'm going to go ahead and merge this one, we can always make another change later on if needed. |
|
@Mergifyio backport galactic foxy |
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
This is inconsistent with having the boxes be cut-n-paste. We also have to rewrite a small amount of text around it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 35c4367)
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
This is inconsistent with having the boxes be cut-n-paste. We also have to rewrite a small amount of text around it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 35c4367)
|
Command
|
clalancette
added a commit
that referenced
this pull request
Sep 7, 2021
This is inconsistent with having the boxes be cut-n-paste. We also have to rewrite a small amount of text around it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 35c4367) Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Sep 7, 2021
This is inconsistent with having the boxes be cut-n-paste. We also have to rewrite a small amount of text around it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 35c4367) Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inconsistent with having the boxes be cut-n-paste.
We also have to rewrite a small amount of text around it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix #1885