Update CI workflow #372
Closed
Update CI workflow #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jacobperron
commented
Feb 7, 2022
jacobperron
commented
- Pin to stable versions of ros-tooling actions
- Remove overlayed version of ament_lint from workspace
- The related PR has been merged and we should be linting against the version in Foxy anyways
- Do not test against macOS; it is no longer a supported platform for Foxy
- Pull dependencies from the testing repository
- Pin to stable versions of ros-tooling actions - Remove overlayed version of ament_lint from workspace - The related PR has been merged and we should be linting against the version in Foxy anyways - Do not test against macOS; it is no longer a supported platform for Foxy - Pull dependencies from the testing repository Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
approved these changes
Feb 7, 2022
Probably? I opened this PR in response to #369 (comment) |
|
Looks like there's still some ongoing work upstream related to Windows: ros-tooling/action-ros-ci#719 |
- Pin version of pip - See actions/runner-images#5027 - Target Windows 2019 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Until someone has the cycles to investigate the build failure. We're already covered by ci.ros2.org anyways. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Sep 1, 2022
|
We decided to remove the CI workflow altogether in #417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.