Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily restrict pip version on Windows to avoid failures #467

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

christophebedard
Copy link
Member

See ros-tooling/action-ros-ci#719 (comment)

Once pip releases a new version with the fix (pypa/pip#10875), we can revert this.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard requested a review from a team as a code owner February 13, 2022 17:48
@christophebedard christophebedard requested review from emersonknapp and Karsten1987 and removed request for a team February 13, 2022 17:48
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #467 (dcef3f9) into master (3e3bb87) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head dcef3f9 differs from pull request most recent head efe079c. Consider uploading reports for the commit efe079c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   93.12%   93.16%   +0.04%     
==========================================
  Files           8        8              
  Lines         160      161       +1     
  Branches       14       14              
==========================================
+ Hits          149      150       +1     
  Misses         11       11              
Impacted Files Coverage Δ
src/setup-ros-windows.ts 78.12% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3bb87...efe079c. Read the comment docs.

@christophebedard
Copy link
Member Author

christophebedard commented Feb 13, 2022

The Windows jobs probably still won't pass (see ros-tooling/action-ros-ci#719), but if this PR fixes the pip issue (i.e., no The process 'C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts\pip3.exe' failed with exit code 3221225477 errors) then we can merge it. nevermind

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Copy link
Member Author

cc @wmmc88

@christophebedard christophebedard changed the title Temporarily pin pip version on Windows to avoid failures Temporarily restrict pip version on Windows to avoid failures Feb 14, 2022
@christophebedard christophebedard merged commit 4c0f37d into master Feb 14, 2022
@christophebedard christophebedard deleted the christophebedard/pin-pip-version-windows branch February 14, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants