New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip installation of rti Connext 6.0.1 #869
skip installation of rti Connext 6.0.1 #869
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really against this change, but I also admit I don't understand why it is needed. Has action-ros-ci been broken since 2022?
Ok so I looked a bit closer at this The current behavior is that it tries to install the package and fails because the license is not accepted (more history at the end of this comment)
It's not really optimal to download 150MB deb that then fails to install. We could go one of 2 ways:
History: |
Thanks for the additional analysis here, it is much appreciated. Ultimately I'll leave the call here up to @christophebedard , but my opinion is that we should do option 2 and take this PR as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Given the ways things are currently, this is simpler.
Given that users are reportedly currently not able to successfully install Connext 6.0.1 using |
Otherwise it tends to hang forever: #523
Connext 6.0.1 version is used for ROS Humble and up
https://www.ros.org/reps/rep-2000.html