Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip installation of rti Connext 6.0.1 #869

Merged

Conversation

mikaelarguedas
Copy link
Contributor

Otherwise it tends to hang forever: #523

Connext 6.0.1 version is used for ROS Humble and up
https://www.ros.org/reps/rep-2000.html

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas requested a review from a team as a code owner May 7, 2024 00:37
@mikaelarguedas mikaelarguedas requested review from gbiggs and christophebedard and removed request for a team May 7, 2024 00:37
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really against this change, but I also admit I don't understand why it is needed. Has action-ros-ci been broken since 2022?

@mikaelarguedas
Copy link
Contributor Author

I'm not really against this change, but I also admit I don't understand why it is needed. Has action-ros-ci been broken since 2022?

Ok so I looked a bit closer at this

The current behavior is that it tries to install the package and fails because the license is not accepted (more history at the end of this comment)

  config: RTI license agreement for non-commercial and pre-commercial use NOT accepted.
  rti-connext-dds-6.0.1: RTI license agreement for non-commercial and pre-commercial use NOT accepted.
  dpkg: error processing archive /var/cache/apt/archives/rti-connext-dds-6.0.1_6.0.1.25-1_amd64.deb (--unpack):
   new rti-connext-dds-6.0.1 package pre-installation script subprocess returned error exit status 10
  Errors were encountered while processing:
   /var/cache/apt/archives/rti-connext-dds-6.0.1_6.0.1.25-1_amd64.deb
  E: Sub-process /usr/bin/dpkg returned an error code (1)

It's not really optimal to download 150MB deb that then fails to install.

We could go one of 2 ways:

  • Actually install connext on action-ros-ci -> remove the skip key rti-* and accept the licence
  • Not install connext and merge this PR as is

History:
The installation was hanging (pretty unclear why) so the skip key was added #523
This had a side effect of removing the noninteractive impacting other packages: #701
Since noninteractive mode is on it doesnt hang but downloads the deb and then fails to install it

@clalancette
Copy link
Contributor

We could go one of 2 ways:

* Actually install connext on action-ros-ci -> remove the skip key rti-* and accept the licence

* Not install connext and merge this PR as is

Thanks for the additional analysis here, it is much appreciated. Ultimately I'll leave the call here up to @christophebedard , but my opinion is that we should do option 2 and take this PR as-is.

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Given the ways things are currently, this is simpler.

@christophebedard christophebedard merged commit 6431a16 into ros-tooling:master May 14, 2024
26 of 38 checks passed
@christophebedard
Copy link
Member

Given that users are reportedly currently not able to successfully install Connext 6.0.1 using action-ros-ci, I think it should be good to release this as a new patch release: 0.3.12.

@mikaelarguedas mikaelarguedas deleted the skip-connext-6-0-1 branch May 14, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants